Added (experimental) non-interactive mode option for genkit init
#140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDoyle
changed the title
genkit initgenkit init
MichaelDoyle
approved these changes
May 13, 2024
| .option( | ||
| '--non-interactive', | ||
| 'Run init in non-interactive mode (experimental)' | ||
| ) |
There was a problem hiding this comment.
What do you think about doing --interactive with a default setting of "true"?
Might help with some of the double-negatives later on.
!nonInteractive
and
!process.argv.includes('--non-interactive')
There was a problem hiding this comment.
General recommendation is to avoid boolean flags with default value of true...
There was a problem hiding this comment.
ok 😄 I could see why (--non-interactive vs --interactive=false) it's just a readability thing in the code itself to consider from my perspective.
alternatively, could try and come up w/ something "positive" like --skip-prompts, but let's not spin our wheels on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.