fix(js): test on node versions 20 through 22; 23 is currently broken #1995

[yesudeep]

fix(js): test on node versions 20 through 22; 23 is currently broken #1995

ISSUE: #1995

CHANGELOG:

• Update biome configuration to use arrow function arg parens always.
• Update github workflows to test on node versions 20 through 22.
• We will add version 23 post fixes.
• Set node 22 to be the default for our eng workstations in the
  setup script for now.
  REFERENCES:

The configuration for the formatting is more or less based on the Google
TypeScript formatting guidelines at:

• https://google.github.io/styleguide/tsguide.html#string-literals
• https://google.github.io/styleguide/jsguide.html
• https://google.github.io/styleguide/tsguide.html#arrow-function-bodies
• https://google.github.io/styleguide/tsguide.html#automatic-semicolon-insertion

Checklist (if applicable):

• PR title is following https://www.conventionalcommits.org/en/v1.0.0/
• Tested (manually, unit tested, etc.)
• Docs updated (updated docs or a docs bug required)

[mbleigh]

One comment on Node versions to test, but I'll leave to @pavelgj to decide if we want to do this for sure.

[MichaelDoyle]

Maybe you all already discussed, and I am an outlier here... but... can we separate out the toolchain changes from the style changes into separate PRs?

Some of the changes in formatting seem good. But others seem superfluous, and some even go against the style guide. Particularly, removing parens around all of the arrow functions goes against:

Parentheses around the left-hand side of a single-argument arrow function are recommended but not required.

And is a huge part of the overall diff here.

[pavelgj]

Maybe you all already discussed, and I am an outlier here... but... can we separate out the toolchain changes from the style changes into separate PRs?

Some of the changes in formatting seem good. But others seem superfluous, and some even go against the style guide. Particularly, removing parens around all of the arrow functions goes against:

Parentheses around the left-hand side of a single-argument arrow function are recommended but not required.

And is a huge part of the overall diff here.

I'm a little caught by surprise here....
I'm personally pretty happy with prettier and not sure we need to change it.

[yesudeep]

Maybe you all already discussed, and I am an outlier here... but... can we separate out the toolchain changes from the style changes into separate PRs?

Some of the changes in formatting seem good. But others seem superfluous, and some even go against the style guide. Particularly, removing parens around all of the arrow functions goes against:

Parentheses around the left-hand side of a single-argument arrow function are recommended but not required.

And is a huge part of the overall diff here.

Fixed. I'll separate the toolchain changes from the formatting for easier review as well.

[yesudeep]

Maybe you all already discussed, and I am an outlier here... but... can we separate out the toolchain changes from the style changes into separate PRs?
Some of the changes in formatting seem good. But others seem superfluous, and some even go against the style guide. Particularly, removing parens around all of the arrow functions goes against:

Parentheses around the left-hand side of a single-argument arrow function are recommended but not required.

And is a huge part of the overall diff here.

I'm a little caught by surprise here.... I'm personally pretty happy with prettier and not sure we need to change it.

4x-12x for our codebase is a significant speed up with no loss of functionality.

zsh❯ hyperfine -i "pnpm run format:biome" "pnpm run format:prettier"
Benchmark 1: pnpm run format:biome
  Time (mean ± σ):     453.6 ms ±   5.6 ms    [User: 679.3 ms, System: 92.5 ms]
  Range (min … max):   447.9 ms … 465.3 ms    10 runs

  Warning: Ignoring non-zero exit code.

Benchmark 2: pnpm run format:prettier
  Time (mean ± σ):      5.715 s ±  0.285 s    [User: 9.578 s, System: 0.739 s]
  Range (min … max):    5.506 s …  6.426 s    10 runs

Summary
  pnpm run format:biome ran
   12.60 ± 0.65 times faster than pnpm run format:prettier

I'll keep prettier in this PR and continue the discussion on [discord]

[yesudeep]

How do I trigger the pending CI checks? It looks like they are stalled.