[Go] reorganize and document #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the API nicer. - Unexport symbols that don't need to be visible. - Write documentation some undocumented symbols.
|
Apologies for the big PR. Everything is just renaming and movement. No change in functionality. It might help to review each commit separately. The first just renames and unexports. The second creates new packages. |
randall77
approved these changes
May 20, 2024
go/genkit/dev_server_test.go
Outdated
| @@ -24,6 +24,7 @@ import ( | |||
| "strings" | |||
| "testing" | |||
|
|
|||
| gtrace "github.com/firebase/genkit/go/trace" | |||
There was a problem hiding this comment.
The impulse to use an import alias for each import suggests that the package name should actually be gtrace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the API nicer.
Unexport symbols that don't need to be visible.
Write documentation for some undocumented symbols.