Skip to content

Add ajv-formats to schema validation #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2024
Merged

Add ajv-formats to schema validation #228

merged 3 commits into from
May 24, 2024

Conversation

sqrrrl
Copy link
Contributor

@sqrrrl sqrrrl commented May 23, 2024 •
edited
Loading

Adds ajv-format to support JSON schema types. Fixes #227

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Changelog updated
  • Docs updated

@maxl0rd
Copy link
Contributor

maxl0rd commented May 23, 2024

Thanks!

Can you also pnpm install and include the changes to pnpm-lock.yaml ?

@pavelgj pavelgj merged commit 80e32f5 into firebase:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelgj pavelgj pavelgj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JS] date/time formats in schema cause error
3 participants
@sqrrrl @maxl0rd @pavelgj