Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] added action type and subtype span metadata to actions #229

Merged
merged 2 commits into from
May 24, 2024

Conversation

pavelgj
Copy link
Collaborator

@pavelgj pavelgj commented May 23, 2024

This is to make sure that spans are properly rendered in the Dev UI

image

@pavelgj pavelgj changed the title Added action type and subtype span metadata to actions [Go] added action type and subtype span metadata to actions May 23, 2024
@pavelgj pavelgj marked this pull request as ready for review May 23, 2024 13:16
@pavelgj pavelgj requested a review from jba May 23, 2024 13:16
@jba
Copy link
Contributor

jba commented May 24, 2024

Thanks.

@pavelgj pavelgj merged commit 90d3edb into main May 24, 2024
5 checks passed
@pavelgj pavelgj deleted the pavelgj/gosubtype branch May 24, 2024 14:48
jba added a commit that referenced this pull request May 24, 2024
This PR greatly simplifies the genkit package, limiting it to
the symbols that Genkit app developers, as exemplified by
the programs in the "samples" directory, would need.

To accomplish this, it moves most of the code to a new package, named
core. The core package, rather than the genkit package, is now imported
by the ai package and plugins. End-user applications should not normally
require it.

This overlapped with #229, so unfortunately those (minor) changes
are incorporated here as well, in a slightly different form.
jba added a commit that referenced this pull request May 24, 2024
This PR greatly simplifies the genkit package, limiting it to
the symbols that Genkit app developers, as exemplified by
the programs in the "samples" directory, would need.

To accomplish this, it moves most of the code to a new package, named
core. The core package, rather than the genkit package, is now imported
by the ai package and plugins. End-user applications should not normally
require it.

This overlapped with #229, so unfortunately those (minor) changes
are incorporated here as well, in a slightly different form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants