Improving dotprompt plugin #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- defineDotprompt() no longer requires plugin loading - plugin still needs to be loaded for prompt files - new registry path for code-defined prompts - validated compatibility with esm modules
pavelgj
approved these changes
May 23, 2024
| @@ -2,7 +2,7 @@ | |||
| "name": "menu", | |||
| "version": "1.0.0", | |||
| "description": "A Genkit test app for understanding a restaurant menu", | |||
| "main": "lib/index.js", | |||
| "main": "./lib/src/index.js", | |||
There was a problem hiding this comment.
Possibly because we are importing some json modules, it creates lib/data and lib/src.
ianlancetaylor
added a commit
that referenced
this pull request
May 28, 2024
Corresponds to TypeScript PR #231.
ianlancetaylor
added a commit
that referenced
this pull request
May 28, 2024
Corresponds to TypeScript PR #231.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses friction with defineDotprompt and ESM modules.