[Go] production server #233
Conversation
|
@pavelgj WDYT of the API here?
I know the names don't quite align; do you have suggestions? |
go/genkit/servers.go
Outdated
| @@ -280,6 +229,189 @@ type listFlowStatesResult struct { | |||
| ContinuationToken string `json:"continuationToken"` | |||
| } | |||
|
|
|||
| // Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
What is this copyright message doing down here?
|
I tried to do a poor person's CL stack by making two separate commits. It took the message from the first instead of the second. I edited the top comment. I meant to suggest reviewing the commits separately. |
go/genkit/servers.go
Outdated
| switch e := currentEnvironment(); e { | ||
| case EnvironmentDev: | ||
| return StartDevServer(addr) | ||
| case EnvironmentProd: | ||
| return StartProdServer(addr) | ||
| default: | ||
| return fmt.Errorf("unknown environment value: %q", e) | ||
| } |
There was a problem hiding this comment.
the idea is that StartProdServer should always start (regardless of currentEnvironment()), even in dev mode. Dev (reflection API) server should only run in dev mode.
So the logic here should be:
if currentEnvironment() == EnvironmentDev {
StartDevServer(addr)
}
StartProdServer(addr)
There was a problem hiding this comment.
Ah, I see. I was going about this wrong.
I removed StartServer and changed StartProdServer to StartFlowServer.
When you call StartFlowServer, you'll get a dev server too.
This commit renames dev_server* to servers*.
Implement NewFlowServeMux, which returns an http.ServeMux that has a route for each defined flow. Provide convenience functions for using that ServeMux as a server, and also for selecting which server to use based on the current development environment.
Implement NewFlowServeMux, which returns an http.ServeMux
that has a route for each defined flow.
Provide convenience functions for using that ServeMux as a server,
and also for selecting which server to use based on the current
development environment.