Skip to content

feat(go): add batch evaluator #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

feat(go): add batch evaluator #2388

merged 3 commits into from
Mar 20, 2025

Conversation

ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Mar 19, 2025

Fixes: #2054

Checklist (if applicable):

@ssbushi
Copy link
Contributor Author

ssbushi commented Mar 19, 2025

@apascal07 I'm unable to understand if the test failures is related to the current PR, can you PTAL? Thanks!

@apascal07
Copy link
Collaborator

@apascal07 I'm unable to understand if the test failures is related to the current PR, can you PTAL? Thanks!

=== RUN   TestBatchEvaluator
{TestCaseId: Input:hello world Output:<nil> Context:[] Reference:<nil> TraceIds:[]}
{TestCaseId: Input:Foo bar Output:<nil> Context:[] Reference:<nil> TraceIds:[]}
    evaluator_test.go:276: got <nil>, want test-options
--- FAIL: TestBatchEvaluator (0.00s)

Seems to be yeah. This is the only failure that I can see.

Copy link
Collaborator

@apascal07 apascal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than error return change.

@ssbushi ssbushi merged commit 4b06946 into main Mar 20, 2025
8 checks passed
@ssbushi ssbushi deleted the sb/gobatchEvals branch March 20, 2025 19:07
kirgrim pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Go] Add evaluator primitive support
2 participants