[Go] fix go generate #243
Merged
[Go] fix go generate #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some new types were added, and a new aspect of JSON Schema that the code generator didn't know about. The new aspect is that a "$ref" can refer to a property inside a schema. The code generator still doesn't understand these, but the config file handles them by ignoring them or replacing them with another type.
ianlancetaylor
approved these changes
May 24, 2024
| @@ -39,10 +53,16 @@ const ( | |||
| FinishReasonUnknown FinishReason = "unknown" | |||
| ) | |||
|
|
|||
| type DataPart struct { | |||
There was a problem hiding this comment.
Should this be dataPart? The other Part types (textPart, mediaPart) are not exported.
| @@ -144,16 +148,27 @@ ToolResponsePartToolResponse pkg ai | |||
| Part pkg ai | |||
| TextPart pkg ai | |||
| TextPart name textPart | |||
| TextPart.data omit | |||
There was a problem hiding this comment.
Any idea what these new Part fields are used for? Should we be using them in document.go somehow?
There was a problem hiding this comment.
I've asked Keith to look into this. I just got things working so I could continue my API refactoring.
There was a problem hiding this comment.
I think the js side just split the part that we call "blob" into two, "media" and "data". I will make that same change in our code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new types were added, and a new aspect of JSON Schema
that the code generator didn't know about.
The new aspect is that a "$ref" can refer to a property
inside a schema. The code generator still doesn't understand
these, but the config file handles them by ignoring them or
replacing them with another type.