Skip to content

refactor(py/genkit-ai): genkit.core.typing -> genkit.typing to avoid manual re-exporting #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Mar 29, 2025

typing modules are standard practice, so promoting ours to top level.

CHANGELOG:

  • Move genkit.core.typing -> genkit.typing so we don't
    have to keep re-exporting each type by hand.

@yesudeep yesudeep enabled auto-merge (squash) March 29, 2025 08:28
@yesudeep yesudeep force-pushed the yesudeep/fix/exciting-sneeze branch from 26f138a to 621a990 Compare March 29, 2025 08:29
@yesudeep yesudeep changed the title refactor(py/genkit): genkit.core.typing -> genkit.typing to avoid manual re-exporting refactor(py/genkit-ai): genkit.core.typing -> genkit.typing to avoid manual re-exporting Mar 29, 2025
@yesudeep yesudeep force-pushed the yesudeep/fix/exciting-sneeze branch 5 times, most recently from cc71e62 to 411ee1f Compare March 29, 2025 08:55
@yesudeep yesudeep force-pushed the yesudeep/fix/exciting-sneeze branch 2 times, most recently from 83544a5 to ee8e553 Compare March 29, 2025 12:22
…manual re-exporting

RATIONALE:
`typing` modules are standard practice, so promoting ours to top-level.

CHANGELOG:
- [ ] Move `genkit.core.typing` -> `genkit.typing` so we don't
      have to keep re-exporting each type by hand.
@yesudeep yesudeep force-pushed the yesudeep/fix/exciting-sneeze branch from ee8e553 to d150743 Compare March 29, 2025 12:23
@yesudeep yesudeep merged commit 27f409c into main Mar 29, 2025
7 checks passed
@yesudeep yesudeep deleted the yesudeep/fix/exciting-sneeze branch March 29, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants