Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] replace Embedder interface with EmbedderAction #349

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

jba
Copy link
Contributor

@jba jba commented Jun 7, 2024

Remove the Embedder interface. Replace it with a type
alias to an Action with the appropriate type parameters.

@jba jba requested review from ianlancetaylor and pavelgj June 7, 2024 15:15
@jba jba force-pushed the jba-googlecloud-plugin branch from 70cd116 to c8e5cd0 Compare June 7, 2024 17:49
Base automatically changed from jba-googlecloud-plugin to main June 7, 2024 17:57
Remove the Embedder interface. Replace it with a type
alias to an Action with the appropriate type parameters.
@jba jba force-pushed the jba-embedder-redo branch from 3a0a11b to 17d32ce Compare June 7, 2024 17:58
@jba jba merged commit 5ca283b into main Jun 7, 2024
5 checks passed
@jba jba deleted the jba-embedder-redo branch June 7, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants