feat(js/plugins/ollama): migrate ollama plugin to v2 plugin API #3547
+192
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
reviewed
Sep 16, 2025
cabljac
reviewed
Sep 16, 2025
cabljac
reviewed
Sep 16, 2025
cabljac
reviewed
Sep 16, 2025
cabljac
reviewed
Sep 16, 2025
cabljac
reviewed
Sep 16, 2025
HassanBahati
commented
Sep 18, 2025
CorieW
reviewed
Sep 26, 2025
js/plugins/ollama/src/embeddings.ts
Outdated
| }, | ||
| async (input, config) => { | ||
| const serverAddress = config?.serverAddress || options.serverAddress; | ||
| const serverAddress = options.serverAddress || 'http://localhost:11434'; |
There was a problem hiding this comment.
Where does that address come from? Is there no better alternatives than having this?
cabljac
reviewed
Sep 29, 2025
js/plugins/ollama/src/embeddings.ts
Outdated
| }, | ||
| async (input, config) => { | ||
| const serverAddress = config?.serverAddress || options.serverAddress; | ||
| const serverAddress = options.serverAddress || 'http://localhost:11434'; |
There was a problem hiding this comment.
We're no longer getting serverAddress from config, because (as far as i understand) it doesn't exist on that interface any more in v2 API.
Can we mention this in the PR description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3456
Note:
We're no longer getting
serverAddressfrom config, because it doesn't exist on that interface any more in v2 API.Checklist (if applicable):