Skip to content

fix(go/ai): enable use of media URIs in prompts #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(go/ai): enable use of media URIs in prompts #3630

wants to merge 2 commits into from

Conversation

hugoaguirre
Copy link
Contributor

@hugoaguirre hugoaguirre commented Sep 23, 2025 •
edited
Loading

Previously, .prompt files were not supporting gs:// and http(s): URIs

Checklist (if applicable):

@github-actions github-actions bot added the go label Sep 23, 2025
@hugoaguirre hugoaguirre marked this pull request as ready for review September 23, 2025 15:51
apascal07
apascal07 reviewed Sep 23, 2025
View reviewed changes
go/samples/prompts/main.go
resp, err := prompt.Execute(ctx)
resp, err := prompt.Execute(ctx,
ai.WithModelName("googleai/gemini-2.5-pro"),
ai.WithInput(map[string]any{"videoUrl": "https://www.youtube.com/watch?v=K-hY0E6cGfo video/mp4"}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is providing the content type like this really standard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how it got implemented in dotprompt package for both JS and Go. The parser splits the URI in two, the right side is always the contentType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apascal07 apascal07 Awaiting requested review from apascal07

@rutujaD1999 rutujaD1999 Awaiting requested review from rutujaD1999

1 more reviewer

@krishnaKapadia krishnaKapadia krishnaKapadia approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
go
Projects
Genkit Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugoaguirre @apascal07 @krishnaKapadia