[Go] proposal: AI types have methods #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlancetaylor
approved these changes
Jun 13, 2024
pavelgj
approved these changes
Jun 13, 2024
randall77
approved these changes
Jun 13, 2024
Calling Retrieve on a retriever as a method is more natural in Go than calling a top-level function, as we currently have. This PR changes Indexer and Retriever from being aliases of Actions to being their own types, allowing methods. Subsequent PRs will do the same for Model, Embedder and possibly Tool.
jba
force-pushed
the
jba-retriever-nonalias
branch
from
e587197 to
a50d98b
Compare
jba
added a commit
that referenced
this pull request
Jun 24, 2024
This continues the work begun in #402 of making the main ai types distinct from their underlying actions, instead of aliases. This allows the types to have methods, unstead of using top-level functions. It also clarifies documentation and other output, like panic stack traces.
jba
added a commit
that referenced
this pull request
Jun 24, 2024
jba
added a commit
that referenced
this pull request
Jun 24, 2024
This continues the work begun in #402 of making the main ai types distinct from their underlying actions, instead of aliases. This allows the types to have methods, unstead of using top-level functions. It also clarifies documentation and other output, like panic stack traces.
jba
added a commit
that referenced
this pull request
Jun 24, 2024
This continues the work begun in #402 of making the main ai types distinct from their underlying actions, instead of aliases. This allows the types to have methods, unstead of using top-level functions. It also clarifies documentation and other output, like panic stack traces.
jba
added a commit
that referenced
this pull request
Jun 24, 2024
jba
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling Retriever on a retriever as a method is more natural
in Go than calling a top-level function, as we currently have.
This PR changes Indexer and Retriever from being aliases of Actions
to being their own types, allowing methods.
If we like this, then a followup PR would do the same for
Model, Embedder and possibly Tool.