Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugins/firebase] defineFirestoreRetriever: Allow supplying collection at retrieval time #443

Merged
merged 3 commits into from
Jun 21, 2024
Merged

[plugins/firebase] defineFirestoreRetriever: Allow supplying collection at retrieval time #443

merged 3 commits into from
Jun 21, 2024

Conversation

mbleigh
Copy link
Collaborator

@mbleigh mbleigh commented Jun 21, 2024

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Docs updated

@mbleigh mbleigh requested a review from pavelgj June 21, 2024 17:39
@pavelgj
Copy link
Collaborator

pavelgj commented Jun 21, 2024

Can you elaborate on the use-case? I'm trying to check whether this impacts tracing and playground (should be fine, I believe).

@mbleigh
Copy link
Collaborator Author

mbleigh commented Jun 21, 2024

Wrote this real quick after seeing #394

If you use subcollections e.g. users/{id}/messages then you need to be able to supply the collection name at retrieval time because it's not fixed.

@mbleigh mbleigh merged commit 67a38bf into main Jun 21, 2024
4 checks passed
@mbleigh mbleigh deleted the dfr-collection branch June 21, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelgj pavelgj pavelgj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbleigh @pavelgj