Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] add version to attribution headers #606

Merged
merged 2 commits into from
Jul 15, 2024
Merged

[Go] add version to attribution headers #606

merged 2 commits into from
Jul 15, 2024

Conversation

jba
Copy link
Contributor

@jba jba commented Jul 12, 2024

Add a version file that contains the current tagged version.

Also add a test for googleai.
It's harder to test vertexai because it uses gRPC.

Also ran go mod tidy.

Add a version file that contains the current tagged version.

Also add a test for googleai.
It's harder to test vertexai because it uses gRPC.

Also ran `go mod tidy`.
@jba jba requested review from pavelgj and ianlancetaylor July 12, 2024 20:12
@jba
Copy link
Contributor Author

jba commented Jul 12, 2024

@pavelgj Where can I document that the version in internal/version.go must be updated before a new Go release is tagged?

go/internal/version.go Outdated Show resolved Hide resolved
Co-authored-by: Pavel Jbanov <pavelj@google.com>
@jba jba merged commit 329cfa5 into main Jul 15, 2024
5 checks passed
@jba jba deleted the jba/version branch July 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants