Skip to content

Handle lack of project id in the firebase plugin in dev. #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Handle lack of project id in the firebase plugin in dev. #624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4282383
Handle lack of project id in the firebase plugin in dev.
kmandrika Jul 15, 2024
f5c7d1c
Apply feedback
kmandrika Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions js/plugins/firebase/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
* limitations under the License.
*/

import { genkitPlugin, Plugin } from '@genkit-ai/core';
import { genkitPlugin, isDevEnv, Plugin } from '@genkit-ai/core';
import { logger } from '@genkit-ai/core/logging';
import { FirestoreStateStore } from '@genkit-ai/flow';
import {
GcpLogger,
Expand Down Expand Up @@ -43,7 +44,7 @@ export const firebase: Plugin<[FirestorePluginParams] | []> = genkitPlugin(
async (params?: FirestorePluginParams) => {
const authClient = new GoogleAuth();
const gcpOptions = {
projectId: params?.projectId || (await authClient.getProjectId()),
projectId: params?.projectId || (await getProjectId(authClient)),
telemetryConfig: params?.telemetryConfig,
};
return {
Expand All @@ -68,3 +69,16 @@ export const firebase: Plugin<[FirestorePluginParams] | []> = genkitPlugin(
};
}
);

async function getProjectId(authClient: GoogleAuth): Promise<string> {
if (isDevEnv()) {
return await authClient.getProjectId().catch((err) => {
logger.warn(
'WARNING: unable to determine Project ID, run "gcloud auth application-default login --project MY_PROJECT_ID"'
);
return '';
});
}

return await authClient.getProjectId();
}