Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidated registry into a class, made registry hierarchical #639

Merged
merged 12 commits into from
Aug 12, 2024

Conversation

pavelgj
Copy link
Collaborator

@pavelgj pavelgj commented Jul 16, 2024

No description provided.

@pavelgj pavelgj requested review from MichaelDoyle, mbleigh and apascal07 and removed request for MichaelDoyle July 16, 2024 23:53
js/core/src/registry.ts Outdated Show resolved Hide resolved
js/core/src/registry.ts Outdated Show resolved Hide resolved
@pavelgj pavelgj requested a review from apascal07 July 17, 2024 17:27
js/core/src/registry.ts Outdated Show resolved Hide resolved
js/core/src/registry.ts Outdated Show resolved Hide resolved
@pavelgj pavelgj requested a review from apascal07 July 17, 2024 19:03
@pavelgj pavelgj changed the title feat: made registry hierarchical, allowing ephemeral child registries for testing and isolated ones for libraries feat: made registry hierarchical, allowing temp and isolated child registries for testing Jul 22, 2024
@pavelgj
Copy link
Collaborator Author

pavelgj commented Jul 26, 2024

Ping

@mbleigh
Copy link
Collaborator

mbleigh commented Jul 26, 2024

What about withRegistry(), withTempRegistry()? I'm not sure withIsolatedRegistry has a lot of utility

@mbleigh
Copy link
Collaborator

mbleigh commented Jul 26, 2024

Also should withTempRegistry perhaps have a way to be used without being a wrapper function? So you could do something like:

before(() => {
  enableTempRegistry();
});

after(() => {
  cleanupTempRegistry();
});

// then all your tests

@pavelgj pavelgj force-pushed the pj/hierarchicalRegistry branch from 90cfedf to 7f47bce Compare August 12, 2024 18:30
@pavelgj pavelgj changed the title feat: made registry hierarchical, allowing temp and isolated child registries for testing refactor: consolidated registry into a class, made registry hierarchical Aug 12, 2024
@pavelgj pavelgj changed the base branch from main to next August 12, 2024 18:38
@pavelgj
Copy link
Collaborator Author

pavelgj commented Aug 12, 2024

Also should withTempRegistry perhaps have a way to be used without being a wrapper function? So you could do something like:

before(() => {
  enableTempRegistry();
});

after(() => {
  cleanupTempRegistry();
});

// then all your tests

Simplified this PR, it's just about consolidating registry into a class -- single global state (registry object)

@pavelgj pavelgj merged commit b9acb11 into next Aug 12, 2024
4 checks passed
@pavelgj pavelgj deleted the pj/hierarchicalRegistry branch August 12, 2024 18:54
cabljac added a commit that referenced this pull request Sep 16, 2024
* feat: do not allow defining new actions from within other actions/flows (#725)

* refactor: [JS] introduced a generate utility action to make generate veneer logic reusable (#759)

Co-authored-by: Michael Bleigh <bleigh@google.com>

* refactor: consolidated registry into a class, made registry hierarchical (#639)

* Add DatasetStore interfaces for evals datasets (#781)

* [Fix] Apply #777 to `next` branch (#779)

* Merge main to Next (#792)

* Update index.md (#764)

* test(go): add live tests to go ollama plugin (#720)

* test(go): add ollama live test

* test(go): retrieve port info for test container

* chore(go): refactor ollama plugin live test

* test(go): remove docker from ollama live test

* fix context array (#777)

* Update to pnpm v9.7.1 (#786)

---------

Co-authored-by: Peter Friese <peter@peterfriese.de>
Co-authored-by: Jacob Cable <32874567+cabljac@users.noreply.github.com>
Co-authored-by: ssbushi <66321939+ssbushi@users.noreply.github.com>
Co-authored-by: Anthony Barone <tonybaroneee@gmail.com>

* [Eval] Breaking change -- Modify EvalRunKey (#755)

* Makes inputSchema optional for tools. (#822)

* Add datasetId field to eval run key (#827)

* Fixes history rendering of Dotprompt system role. (#837)

* Local file based DatasetStore implementation and Tools API changes (#797)

* feat(js/plugins/ollama): add initial embedding support

* feat(js/plugins/ollama): integrate ollama embeddings into plugin proper

* Update js/plugins/ollama/src/embeddings.ts

Co-authored-by: Pavel Jbanov <pavelj@google.com>

---------

Co-authored-by: Pavel Jbanov <pavelj@google.com>
Co-authored-by: Michael Bleigh <bleigh@google.com>
Co-authored-by: shrutip90 <shruti.p90@gmail.com>
Co-authored-by: ssbushi <66321939+ssbushi@users.noreply.github.com>
Co-authored-by: Sam Phillips <samphillips@google.com>
Co-authored-by: Peter Friese <peter@peterfriese.de>
Co-authored-by: Anthony Barone <tonybaroneee@gmail.com>
Co-authored-by: Michael Doyle <michaeldoyle@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants