Skip to content

fix: unblock spinner on init #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: unblock spinner on init #683

merged 1 commit into from
Jul 25, 2024

Conversation

cabljac
Copy link
Contributor

@cabljac cabljac commented Jul 25, 2024 •
edited
Loading

Resolves #531

Any blocking sync process with stop the spinner in ora.

Checklist (if applicable):

  • Tested (manually)
  • Changelog updated
  • Docs updated

@cabljac cabljac requested a review from apascal07 July 25, 2024 10:37
@cabljac cabljac merged commit 078f550 into main Jul 25, 2024
@cabljac cabljac deleted the @invertase/make-init-non-blocking branch July 25, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apascal07 apascal07 apascal07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Genkit Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tooling] The genkit init spinner doesn't spin when installing npm packages
2 participants
@cabljac @apascal07