refactor(go/plugins/ollama): use ollama go client in plugin #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apascal07
reviewed
Aug 6, 2024
cabljac
force-pushed
the
@invertase/add-ollama-client
branch
from
88a9055
to
fd4acb1
Compare
This was referenced Aug 21, 2024
cabljac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing ollama plugin to use the ollama go client (which is used by ollama itself)
This will keep us in sync with ollama better, and make adding additional features easier as ollama adds them.
The PR also adds in embedders for ollama, resolving #728
During testing I also found some logic which could use a nil pointer check (in the validateCandidate logic, e.g called by generate.go in the
aipackage)Checklist (if applicable):