-
Notifications
You must be signed in to change notification settings - Fork 477
[JS] Split out defineFlow
into stream/non-stream and make flows callable as functions.
#795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
defineFlow
into itself + defineStreamingFlow
with callable interfaces for both.defineFlow
into stream/non-stream and make flows callable as functions.
could you please summarize API changes in the PR description? |
Done. |
ugh, I forgot about this PR... and now I have a change that rips our durable flows, that massively conflicts with this... |
I don't remember, have we discussed this API at some point ([in]formal review with the team)? |
Chris filed this issue (#391) with the resolution based on a discussion where at least you, me, and Michael were involved. |
Ah, I found the discussion. I am a bit torn on splitting out defineFlow and defineStreamingFlow... but I think it might simplify a few thing... so, yeah, LGTM. |
Fixes #391.
Instead of:
You will now do:
Checklist (if applicable):