Skip to content

Conversation

cabljac
Copy link
Contributor

@cabljac cabljac commented Sep 11, 2024

This PR adds JSON mode to Vertex AI plugin.

Note that Vertex AI has the same limitation of not supporting tool calling/function calling and json mode at the same time.

Note this bumps @google-cloud/vertexai and google-auth-library in the plugin.

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Changelog updated
  • Docs updated

@cabljac cabljac force-pushed the @invertase/vertexai-json-mode branch from 101c110 to afb5c4b Compare September 11, 2024 12:25
@cabljac
Copy link
Contributor Author

cabljac commented Sep 11, 2024

This should resolve #290

@cabljac cabljac requested a review from pavelgj September 11, 2024 12:29
@cabljac
Copy link
Contributor Author

cabljac commented Sep 12, 2024

(merge #888 first)

@cabljac cabljac force-pushed the @invertase/vertexai-json-mode branch 2 times, most recently from ffacfa5 to 8008763 Compare September 12, 2024 17:38
@cabljac cabljac marked this pull request as ready for review September 12, 2024 17:41
@cabljac cabljac force-pushed the @invertase/vertexai-json-mode branch 2 times, most recently from bd117a9 to 6cbfa35 Compare September 17, 2024 09:15
@cabljac cabljac force-pushed the @invertase/vertexai-json-mode branch from 6cbfa35 to c47bdc2 Compare September 23, 2024 08:59
@cabljac cabljac merged commit 75a16af into main Sep 23, 2024
4 checks passed
@cabljac cabljac deleted the @invertase/vertexai-json-mode branch September 23, 2024 09:39
@pavelgj
Copy link
Collaborator

pavelgj commented Sep 23, 2024

Please make sure this is applied to the next branch as well

@cabljac cabljac restored the @invertase/vertexai-json-mode branch September 23, 2024 13:48
@cabljac
Copy link
Contributor Author

cabljac commented Sep 23, 2024

@pavelgj and the Google AI equivalent to this, which is in main?

@pavelgj
Copy link
Collaborator

pavelgj commented Sep 23, 2024

@pavelgj and the Google AI equivalent to this, which is in main?

yeah, that too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants