Fix issue #543 : cached key set expiration are not handled #549
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -20,7 +20,8 @@ | |||
| ], | |||
| "license": "BSD-3-Clause", | |||
| "require": { | |||
| "php": "^7.4||^8.0" | |||
| "php": "^7.4||^8.0", | |||
| "ext-json": "*" | |||
There was a problem hiding this comment.
we do not want to introduce a new dependency in the library like this - it could change behavior for existing installations.
| //Check keyId presence | ||
| if (!isset($keySet[$keyId])) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
The whitespace is inconsistent, which makes this hard to review.
|
As far as I can tell, the changes are completely unrelated to the linked issue. Also this PR is unreadable due to incorrect whitespace changes. |
Hello,
This PR aim to fix the issue #543 , as cached key set expiration', are not takken into account.
Thanks,