feat: set SPM=true by default for qs testing

[ncooke3]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the test.sh script to set the SPM environment variable to true by default. This change streamlines the testing process, particularly for 'qs testing', by pre-enabling Swift Package Manager integration without requiring explicit configuration.

Highlights

• Default SPM Value: The default value for the SPM environment variable in the scripts/test.sh script has been changed from false to true.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request modifies the test.sh script to set the default value of the SPM variable to true. This change ensures that the Swift Package Manager is enabled by default for testing. I have identified one potential issue related to the logic flow and provided a suggestion to improve clarity.

[gemini-code-assist]

Setting SPM to true by default could potentially break existing setups that rely on the previous default (false). Consider adding a check to see if SPM is explicitly set to false before defaulting to true, or providing a clear migration path for users who depend on the old behavior.

if [[ -z "${SPM:-}" ]]; then
    SPM=true
    echo "Defaulting to SPM=$SPM"
fi

It might be better to check if it's explicitly set to false first.

Suggested change

	SPM=true
	if [[ -z "${SPM:-}" ]]; then
	SPM=true
	echo "Defaulting to SPM=$SPM"
	fi