Demonstration of WIP Firestore Codable #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Dec 28, 2018
| @@ -74,7 +74,7 @@ class RestaurantsTableViewController: UIViewController, UITableViewDataSource, U | |||
| return | |||
| } | |||
| let models = snapshot.documents.map { (document) -> Restaurant in | |||
| if let model = try? Firestore.Decoder().decode(Restaurant.self, from: document.data()) { | |||
| if let model = try? document.data(as:Restaurant.self) { | |||
There was a problem hiding this comment.
nit: space after colon
|
Replaced by #787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for demonstration only currently and not intended for merging.
This converts part of the Firestore quickstart to use the Codable implementation at firebase/firebase-ios-sdk#2178.
Note that this is based on the original contribution from firebase/firebase-ios-sdk#838 and the API requested by @wilhuff at firebase/firebase-ios-sdk#627 (comment).
The next step is resolving this difference and converging.