-
Notifications
You must be signed in to change notification settings - Fork 133
Fix typo in useremail #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
auth/email_action_links.js
Outdated
@@ -71,14 +71,14 @@ admin | |||
|
|||
// [START sign_in_with_email_link] | |||
// Admin SDK API to generate the sign in with email link. | |||
const usremail = 'user@example.com'; | |||
const useremail = 'user@example.com'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useremail
already exists as a const
above, so we'll have to use a new variable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samtstern Then I'd suggest to be consistent with the other examples and reduce it to a single const
at the top of the file? Well, I see the documentation uses different snippets of this file, so that doesn't help either.
We could wrap the code snippets in a function to allow different scopes to declare the same const
.
(I don't know if that would break the [START sign_in_with_email_link]
parsing)
() => {
// [START sign_in_with_email_link]
// Admin SDK API to generate the sign in with email link.
const useremail = 'user@example.com';
....
// [END sign_in_with_email_link]
}
https://firebase.google.cn/docs/auth/admin/email-action-links?hl=EN-GB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peili yes I think you're right that one function per snippet would be the better approach, just like we do over here:
https://github.com/firebase/snippets-web/blob/master/functions/callable.js#L17
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peili I went ahead and wrapped the code inside a function so that we can get this merged.
Thank you for your contribution!
No description provided.