-
Notifications
You must be signed in to change notification settings - Fork 133
chore: Edited the query filter to remove .get() #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @shweta345 |
@thatfiredev Internal bug ID that it targets is http://b/300413440. I was unsure if I should link it here :) |
@shweta345 I do see the 2 simple queries that the customer seems to be talking about: ![]() But they don't seem to match with the query you're updating in this PR: |
@thatfiredev This is the link that customer has shared: https://cloud.google.com/firestore/docs/query-data/queries#simple_queries. If you see the second snippet, it is the one that I edited. (Node.js language) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shweta345 Ah, my bad. I was looking at the wrong snippet (modular SDK)
One minor change needed before we merge this:
Co-authored-by: Rosário P. Fernandes <rosariofernandes51@gmail.com>
@thatfiredev Merged your edits. Thank you! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for updating this :)
Updated the code to resolve a customer feedback about understanding simple queries due to the .get() function.