refactor: FIR-35471 remove account resolve call #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
approved these changes
Sep 3, 2024
README.md
Outdated
| @@ -17,7 +17,7 @@ go get github.com/firebolt-db/firebolt-go-sdk | |||
| ### Example | |||
| Here is an example of establishing a connection and executing a simple select query. | |||
| For it to run successfully, you have to specify your credentials, and have a default engine up and running. | |||
|
|
|||
| git checkout -b FIR-35471-remove-account-resolve-endpoint-from-go-sdk | |||
There was a problem hiding this comment.
let's remove this, as I assume it was committed by accident
|
stepansergeevitch
deleted the
FIR-35471-remove-account-resolve-endpoint-from-go-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed account resolve call from the client initialization. Also removed account id validation when the endpoint is updated from the backend after USE ENGINE command