Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Timeout custom exception #108

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: Timeout custom exception #108

merged 3 commits into from
Sep 25, 2024

Conversation

stepansergeevitch
Copy link
Collaborator

Added a custom timeout exception to distinguish between actual token cancelation and command execution timeout

@stepansergeevitch stepansergeevitch self-assigned this Sep 25, 2024
@stepansergeevitch stepansergeevitch requested a review from a team as a code owner September 25, 2024 08:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
61.9% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@stepansergeevitch stepansergeevitch merged commit db54a7a into main Sep 25, 2024
6 of 7 checks passed
@stepansergeevitch stepansergeevitch deleted the timeout-custom-exception branch September 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

Assignees

@stepansergeevitch stepansergeevitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepansergeevitch @ptiurin