ci: Fix release build

[stepansergeevitch]

A couple of improvements to release action

• Attemt to fix the build by synchronizing build step with how it's done in other actions
• Moved tag pushing to the end of the action

[github-actions]

File	Coverage		Missing
All files	82%	✅

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against e592739

[ptiurin]

Tag is done before pushing to the software repository in other actions, what are we trying to achieve here? https://github.com/firebolt-db/action-python-release/blob/main/action.yml

[stepansergeevitch]

The problem that has happened is that tag was pushed but release has failed. I believe this logic makes more sense since we should create a tag only after release has succeeded
BTW tag is created after publishing in node sdk as well
https://github.com/firebolt-db/firebolt-node-sdk/blob/main/.github/workflows/release-workflow.yaml#L57

[ptiurin]

I believe this logic makes more sense since we should create a tag only after release has succeeded

This is a chicken and egg problem - if there's a problem with pushing a tag we'll fail, but the driver would already be pushed to the repository. If we rerun it'll be pushed again and I'm not sure what happens if the same tag is pushed twice, will it fail or overwrite? On the other hand, if we fail to push to the remote we have access to quickly delete a tag from our repo and start again.
In any case I'd prefer we keep the release functionality the same across repos, whichever approach we take, and have contingency plans for when it fails.

[stepansergeevitch]

Ok, we can keep the existing order

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud