fix: FIR-33174: parse boolean in old (0/1) and new (false/true) formats #86
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0b02579 |
alexradzin
force-pushed
the
FIR-33174-parse-boolean-in-old-format
branch
from
64a0bde to
400593d
Compare
| public static bool ParseBoolean(string str) | ||
| { | ||
| bool b; | ||
| return booleanValues.TryGetValue(str, out b) ? b : throw new FormatException($"String '{str}' was not recognized as a valid Boolean."); |
There was a problem hiding this comment.
Should this be a case-insensitive comparison? For cases like True and TRUE?
There was a problem hiding this comment.
In fact it should support both true and True because string value arrives here after calling ToString() that turns true into string True and false into string False.
I agree that this is not obvious, so I can either add this text as a comment or add entries for True and False to the dictionary. What do you prefer?
There was a problem hiding this comment.
I see. Eh, just a comment here is fine so we don't forget.
| public static bool ParseBoolean(string str) | ||
| { | ||
| bool b; | ||
| return booleanValues.TryGetValue(str, out b) ? b : throw new FormatException($"String '{str}' was not recognized as a valid Boolean."); |
There was a problem hiding this comment.
I see. Eh, just a comment here is fine so we don't forget.
alexradzin
force-pushed
the
FIR-33174-parse-boolean-in-old-format
branch
from
524d008 to
e2efab2
Compare
alexradzin
force-pushed
the
FIR-33174-parse-boolean-in-old-format
branch
from
e2efab2 to
0b02579
Compare
|
No description provided.