Fir 27646 remove client generated query #302
Conversation
alexradzin
force-pushed
the
FIR-27646-remove-client-generated-query-id
branch
from
63644b0 to
b6c3298
Compare
| } | ||
| Thread.sleep(5000); | ||
| verifyThatNoMoreRecordsAreAdded(connection, "first_statement_cancel_test", totalRecordsToInsert); | ||
| verifyThatNoMoreRecordsAreAdded(connection, "first_statement_cancel_test"); |
There was a problem hiding this comment.
The only insert statement I see in this test is insert into ex_lineitem ( l_orderkey ) SELECT * FROM GENERATE_SERIES(1, 1000)
Why do we check first_statement_cancel_test table then? Shouldn't it be ex_lineitem? I'm probably missing the idea of the test
There was a problem hiding this comment.
Do we ever interact with first_statement_cancel_test and second_statement_cancel_test here?
| log.warn("Could not execute statement", e); | ||
| } | ||
| } | ||
| // @BeforeAll |
There was a problem hiding this comment.
Do we plan to even uncomment this?
In case no, let's just delete this part. In case yes, let's add a comment on top mentioning when do we plan to uncomment this
There was a problem hiding this comment.
uncommented. 10x!
| return quedAborted || runningAborted; | ||
| } | ||
|
|
||
| private boolean abortCallWithId(Optional<Call> call) { |
There was a problem hiding this comment.
nit: abortCallWithId -> abortCall since no id is passed
alexradzin
force-pushed
the
FIR-27646-remove-client-generated-query-id
branch
from
91d885e to
f4bc232
Compare
alexradzin
force-pushed
the
FIR-27646-remove-client-generated-query-id
branch
from
f4bc232 to
09821bf
Compare
|
No description provided.