feat: FIR-43038 allow jdbc to send batch as a single multi statement #494
Conversation
|
| if (sessionProperties.isMergePreparedStatementBatches()) { | ||
| if (!inserts.isEmpty()) { | ||
| execute(List.of(asSingleStatement(inserts))); | ||
| } | ||
| } else { | ||
| execute(inserts); | ||
| } |
There was a problem hiding this comment.
Should we be checking that all of the statements are inserts here? I don't think we have a guarantee of that.
There was a problem hiding this comment.
That's parsing of statement, which I believe we should avoid. Since the new parameter is "internal" (not documented), and is only expected to be used by Debezium, we should be safe. We'll have this properly supported when we'll have server-side multitatements
There was a problem hiding this comment.
Ok, agreed. I was thinking this would be safer if we batched only inserts and everything else would run as before, but for Debezium this should be sufficient.
Let's rename the variable though to avoid confusion, inserts implies we know we have only inserts here.
| try (java.sql.PreparedStatement preparedStatement = connection.prepareStatement("INSERT INTO test_table VALUES (?)")) { | ||
| for (int i = 0; i < 10; i++) { | ||
| preparedStatement.setInt(1, i); | ||
| preparedStatement.addBatch(); | ||
| } | ||
| preparedStatement.executeBatch(); | ||
| } | ||
| try (ResultSet rs = statement.executeQuery("SELECT COUNT(*) FROM test_table")) { | ||
| assertTrue(rs.next()); | ||
| assertEquals(10, rs.getInt(1)); | ||
| } |
There was a problem hiding this comment.
As a potential improvement, to verify this is indeed sent in one batch we can set a query label, then execute batch and check query history for that label. It should have only one result.
Added
merge_prepared_statement_batchesparameter to JDBC. If will send all queries in a prepared statement batch as a single http request, separated by semicolon.