-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zustand console warnings #88
Fix zustand console warnings #88
Conversation
|
Name | Link |
---|---|
🔨 Latest commit | 08791d3 |
I'll create a separate issue for the second point. Need to review pmndrs/zustand#1180 first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Agreed, let's go ahead and merge this one. We can address the second issue in a subsequent PR. Once this is merged, we'll be down to just one warning, a significant improvement from the initial eight warnings :) |
The actual migration guide is written here. https://docs.pmnd.rs/zustand/previous-versions/zustand-v3-create-context#migration |
Agree, I'll check this in locally once and then merge, probably by the next morning. |
Description
Default export
zustand/context
--> this requires refactor for./playgrounds/firecamp-graphql/src/store/store.ts
Screenshots (optional)
Fixes #77