Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in on exit handler causing pipelines to return 0 (success) #1014

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix bug in on exit handler causing pipelines to return 0 (success) #1014

merged 1 commit into from
Oct 27, 2023

Conversation

firecow
Copy link
Owner

@firecow firecow commented Oct 27, 2023 •
edited
Loading

closes #1012

mjn@mjn-laptop:~/workspace/firecow-gitlab-ci-local$ node --version && node src/index.js --cwd ../mjn-gitlab-ci-debugging/; echo $?
v18.17.1
parsing and downloads finished in 49 ms
failing_job starting shell (test)
failing_job $ exit 1
failing_job finished in 11 ms  FAIL 1  

 FAIL  failing_job
pipeline finished in 129 ms
1

Still works in nodejs18

@firecow
Fix bug in on exit process exit code that caused pipelines to always …
3838076 
…be 0 (success) even though jobs where failing left and right
@firecow firecow requested review from atli-c, FnuGk and byrdal October 27, 2023 09:08
@firecow firecow self-assigned this Oct 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@firecow firecow merged commit eb846f9 into master Oct 27, 2023
@firecow firecow deleted the bug-fix-on-exit-process-exit-code branch October 27, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FnuGk FnuGk FnuGk approved these changes

@atli-c atli-c Awaiting requested review from atli-c

@byrdal byrdal Awaiting requested review from byrdal

Assignees

@firecow firecow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exitCode is always zero when using node v20
2 participants
@firecow @FnuGk