-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version information for in-VM agent, shim, firecracker-conta… #377
Conversation
Right now, firecracker-containerd and firecracker-ctr have "some" version information.
The shim is not having any.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goimports
is complaining, but other than the lint issue I think this code looks fine.
-version
flag to the in-VM agentInvestigating issues like firecracker-microvm#370 will be easier if the agent can report the version. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
As like containerd's Makefile, we can fill out version.Revision to make our life easier. https://github.com/containerd/containerd/blob/0a1f2b40642e54ed06cd0a22cdf6025cbe70853c/Makefile#L24 Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Realized that we must not write anything on "start", since the stdin is used for passing the address of the shim.
Will fix! |
Because the shim's flag parsing is owned by containerd's shim package, supporting -version/-v is not straightforward. Instead the binary logs the version. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Since the version strings won't be like "1.2.3", it would be better to communicate the way we generate the strings. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
After the change, the shim will log the line like below;
agent will have
firecracker-containerd follows what containerd does.
|
…ependabot/go_modules/github.com/go-openapi/strfmt-0.21.2 Bump github.com/go-openapi/strfmt from 0.21.1 to 0.21.2
Investigating issues like #370 will be easier if the agent can report
the version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.