Upgrade firecracker to 1.4.1 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
reviewed
Mar 16, 2023
fangn2
force-pushed
the
upgrade-firecracker
branch
from
c112c5e
to
e840cf2
Compare
fangn2
force-pushed
the
upgrade-firecracker
branch
2 times, most recently
from
63ae1a7
to
5b8c168
Compare
|
Waiting for #495 to merge to unblock build issue. |
Thanks! From test perspetive, change that is enough to test with firecracker 1.4.0 |
1. Pull swagger specs from firecracker 2. `go generate` to rebuild the client 3. Upgrade version in the Makefile Signed-off-by: Tony Fang <nhfang@amazon.com>
fangn2
force-pushed
the
upgrade-firecracker
branch
from
5b8c168
to
73ce43b
Compare
swagatbora90
reviewed
Aug 8, 2023
swagatbora90
reviewed
Aug 9, 2023
Signed-off-by: Tony Fang <nhfang@amazon.com>
|
Since firecracker 1.4.1 was released, upgrade to it directly. |
ginglis13
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Upgrade firecracker from 1.0.0 to 1.4.1
Description of changes:
Upgrade firecracker to 1.4.1
firecracker-microvm/firecracker@v1.0.0...v1.4.1
PR #495 has upgraded firecracker partially to 1.4.1(only snapshot memory backend was added, not all swagger specs were in sync with v1.4.1), this PR is a followup to make sure swagger files are in sync and client were generated.
go generateto rebuild the clientMissing features not yet implemented at sdk side are captured in the list.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign-off-by: Tony Fang nhfang@amazon.com