Skip to content

Commit

Permalink
Merge branch 'main' into 4534
Browse files Browse the repository at this point in the history
  • Loading branch information
roypat authored May 7, 2024
2 parents 607492c + 252e85e commit 79d925a
Show file tree
Hide file tree
Showing 42 changed files with 266 additions and 245 deletions.
3 changes: 1 addition & 2 deletions .buildkite/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@

DEFAULT_PLATFORMS = [
("al2", "linux_4.14"),
# TODO: Unpin 5.10 kernel AMI once io_uring issues is solved.
("al2", "linux_5.10-pinned"),
("al2", "linux_5.10"),
("al2023", "linux_6.1"),
]

Expand Down
3 changes: 1 addition & 2 deletions .buildkite/pipeline_cross.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ def cross_steps():

# https://github.com/firecracker-microvm/firecracker/blob/main/docs/kernel-policy.md#experimental-snapshot-compatibility-across-kernel-versions
aarch64_platforms = [
# TODO: unpin kernel 5.10 AMI once we fix io_uring test failures.
("al2", "linux_5.10-pinned"),
("al2", "linux_5.10"),
("al2023", "linux_6.1"),
]
perms_aarch64 = itertools.product(
Expand Down
85 changes: 46 additions & 39 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/acpi-tables/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ license = "Apache-2.0"
displaydoc = "0.2.4"
thiserror = "1.0.59"
vm-memory = { version = "0.14.1", features = ["backend-mmap", "backend-bitmap"] }
zerocopy = { version = "0.7.32", features = ["derive"] }
zerocopy = { version = "0.7.33", features = ["derive"] }

[lib]
bench = false
Expand Down
2 changes: 1 addition & 1 deletion src/cpu-template-helper/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ clap = { version = "4.5.4", features = ["derive", "string"] }
displaydoc = "0.2.4"
libc = "0.2.154"
log-instrument = { path = "../log-instrument", optional = true }
serde = { version = "1.0.199", features = ["derive"] }
serde = { version = "1.0.200", features = ["derive"] }
serde_json = "1.0.116"
thiserror = "1.0.59"

Expand Down
6 changes: 3 additions & 3 deletions src/firecracker/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ log-instrument = { path = "../log-instrument", optional = true }
micro_http = { git = "https://github.com/firecracker-microvm/micro-http" }

seccompiler = { path = "../seccompiler" }
serde = { version = "1.0.199", features = ["derive"] }
serde = { version = "1.0.200", features = ["derive"] }
serde_derive = "1.0.136"
serde_json = "1.0.116"
thiserror = "1.0.59"
Expand All @@ -37,13 +37,13 @@ libc = "0.2.154"
regex = { version = "1.10.4", default-features = false, features = ["std", "unicode-perl"] }

# Dev-Dependencies for uffd examples
serde = { version = "1.0.199", features = ["derive"] }
serde = { version = "1.0.200", features = ["derive"] }
userfaultfd = "0.8.1"

[build-dependencies]
bincode = "1.2.1"
seccompiler = { path = "../seccompiler" }
serde = { version = "1.0.199" }
serde = { version = "1.0.200" }
serde_json = "1.0.116"

[features]
Expand Down
2 changes: 1 addition & 1 deletion src/firecracker/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ enum MainError {
InvalidLogLevel(vmm::logger::LevelFilterFromStrError),
/// Could not initialize logger: {0}
LoggerInitialization(vmm::logger::LoggerUpdateError),
/// Could not initialize metrics: {0:?}
/// Could not initialize metrics: {0}
MetricsInitialization(MetricsConfigError),
/// Seccomp error: {0}
SeccompFilter(FilterError),
Expand Down
6 changes: 3 additions & 3 deletions src/jailer/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ pub enum JailerError {
CgroupInvalidParentPath(),
#[error("Failed to write to cgroups file: {0}")]
CgroupWrite(io::Error),
#[error("Failed to change owner for {0:?}: {1}")]
#[error("Failed to change owner for {0}: {1}")]
ChangeFileOwner(PathBuf, io::Error),
#[error("Failed to chdir into chroot directory: {0}")]
ChdirNewRoot(io::Error),
#[error("Failed to change permissions on {0:?}: {1}")]
#[error("Failed to change permissions on {0}: {1}")]
Chmod(PathBuf, io::Error),
#[error("Failed cloning into a new child process: {0}")]
Clone(io::Error),
Expand Down Expand Up @@ -112,7 +112,7 @@ pub enum JailerError {
ReadLine(PathBuf, io::Error),
#[error("{}", format!("Failed to read file {:?} into a string: {}", .0, .1).replace('\"', ""))]
ReadToString(PathBuf, io::Error),
#[error("Regex failed: {0:?}")]
#[error("Regex failed: {0}")]
RegEx(regex::Error),
#[error("Invalid resource argument: {0}")]
ResLimitArgument(String),
Expand Down
14 changes: 7 additions & 7 deletions src/rebase-snap/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,19 @@ const DEPRECATION_MSG: &str = "This tool is deprecated and will be removed in th

#[derive(Debug, thiserror::Error, displaydoc::Display)]
enum FileError {
/// Invalid base file: {0:?}
/// Invalid base file: {0}
InvalidBaseFile(std::io::Error),
/// Invalid diff file: {0:?}
/// Invalid diff file: {0}
InvalidDiffFile(std::io::Error),
/// Failed to seek data: {0:?}
/// Failed to seek data: {0}
SeekData(std::io::Error),
/// Failed to seek hole: {0:?}
/// Failed to seek hole: {0}
SeekHole(std::io::Error),
/// Failed to seek: {0:?}
/// Failed to seek: {0}
Seek(std::io::Error),
/// Failed to send the file: {0:?}
/// Failed to send the file: {0}
SendFile(std::io::Error),
/// Failed to get metadata: {0:?}
/// Failed to get metadata: {0}
Metadata(std::io::Error),
}

Expand Down
2 changes: 1 addition & 1 deletion src/seccompiler/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ bincode = "1.2.1"
displaydoc = "0.2.4"
libc = "0.2.154"
log-instrument = { path = "../log-instrument", optional = true }
serde = { version = "1.0.199", features = ["derive"] }
serde = { version = "1.0.200", features = ["derive"] }
serde_json = "1.0.116"
thiserror = "1.0.59"

Expand Down
4 changes: 2 additions & 2 deletions src/seccompiler/src/backend.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ pub enum FilterError {
FilterTooLarge,
/// The seccomp rule contains an invalid argument number.
InvalidArgumentNumber,
/// {0:?}
/// {0}
Arch(TargetArchError),
/// Syscall {0} has conflicting rules.
ConflictingRules(i64),
Expand Down Expand Up @@ -1743,7 +1743,7 @@ mod tests {
"{}",
FilterError::Arch(TargetArchError::InvalidString("lala".to_string()))
),
format!("{:?}", TargetArchError::InvalidString("lala".to_string()))
format!("{0}", TargetArchError::InvalidString("lala".to_string()))
);
}

Expand Down
Loading

0 comments on commit 79d925a

Please sign in to comment.