Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Broken S3 Path in Readme for vmlinux. #4454

Closed
3 tasks done
mehedi-shafi opened this issue Feb 15, 2024 · 2 comments · Fixed by #4455
Closed
3 tasks done

[Bug] Broken S3 Path in Readme for vmlinux. #4454

mehedi-shafi opened this issue Feb 15, 2024 · 2 comments · Fixed by #4455

Comments

@mehedi-shafi
Copy link

Describe the bug

The download URL for vmlinux from s3:// is wrong. It should be

https://s3.amazonaws.com/spec.ccfc.min/firecracker-ci/v1.7/${ARCH}/vmlinux-5.10.209

To Reproduce

Try downloading the vmlinux from the getting-started

Expected behaviour

N/A

Environment

N/A

Additional context

N/A

Checks

  • Have you searched the Firecracker Issues database for similar problems?
  • Have you read the existing relevant Firecracker documentation?
  • Are you certain the bug being reported is a Firecracker issue?
roypat added a commit to roypat/firecracker that referenced this issue Feb 16, 2024
@roypat
fix(doc): Update vmlinux artifact link
a3b9fd7 
When regenerating artifacts for firecracker-microvm#4360, the guest kernels got updated to
a new patch version.

Fixes firecracker-microvm#4454

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat mentioned this issue Feb 16, 2024
Merged
9 tasks
zulinx86 pushed a commit that referenced this issue Feb 16, 2024
@roypat @zulinx86
fix(doc): Update vmlinux artifact link
b4b98a2 
When regenerating artifacts for #4360, the guest kernels got updated to
a new patch version.

Fixes #4454

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat
Copy link
Contributor

roypat commented Feb 16, 2024

Hi @mehedi-shafi,

Thanks for reporting this, and sorry for the inconvenience. We've just updated the link, so you should be able to download the example kernel now :)

@mehedi-shafi
Copy link
Author

No problem. I found the link by navigating the link tree anyways. Thanks for the prompt fixing. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(doc): Update vmlinux artifact link roypat/firecracker
2 participants
@mehedi-shafi @roypat