Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the cpuid crate #851

Closed
Tracked by #651
serban300 opened this issue Jan 15, 2019 · 3 comments
Closed
Tracked by #651

Refactor the cpuid crate #851

serban300 opened this issue Jan 15, 2019 · 3 comments
Assignees
@serban300
Labels
Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Milestone
AMD Support

Comments

@serban300
Copy link
Contributor

Refactor the cpuid crate in order to make it easier to add support for new CPUs

Make sure it doesn't affect the boot time
@serban300 serban300 self-assigned this Jan 15, 2019
@raduweiss raduweiss mentioned this issue Jan 15, 2019
Closed
3 tasks
@serban300
Copy link
Contributor Author

filter_cpuid execution time (cpu clock) before refactoring: 6-11 usec

@andreeaflorescu
Copy link
Member

It looks like we should start the work on this with an integration test. It is rather tricky to catch regressions otherwise.

@serban300
Copy link
Contributor Author

I will try to do this incrementally. The first iterations should be covered by the unit tests. I will add an integration test as soon as it is needed.

serban300 pushed a commit to serban300/firecracker that referenced this issue Jan 18, 2019
implement bit helper trait for u32
c7de898 
cpuid crate refactoring - part 1: firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
serban300 pushed a commit to serban300/firecracker that referenced this issue Jan 18, 2019
implement bit helper trait for u32
b873c72 
cpuid crate refactoring - part 1: firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
serban300 pushed a commit to serban300/firecracker that referenced this issue Jan 18, 2019
implement bit helper trait for u32
9cb7a94 
cpuid crate refactoring - part 1: firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
serban300 pushed a commit to serban300/firecracker that referenced this issue Jan 18, 2019
implement bit helper trait for u32
6b0c149 
cpuid crate refactoring - part 1: use helper methods instead of bitwise operations when editing the cpuid

firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
serban300 pushed a commit to serban300/firecracker that referenced this issue Jan 18, 2019
cpuid crate refactoring - part 1: use helper methods instead of bitwi…
fcd61a8 
…se operations when editing the cpuid

firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
@serban300 serban300 mentioned this issue Jan 18, 2019
Merged
serban300 pushed a commit to serban300/firecracker that referenced this issue Jan 21, 2019
cpuid crate refactoring - part 1: use helper methods instead of bitwi…
2d5f175 
…se operations when editing the cpuid

firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
serban300 pushed a commit to serban300/firecracker that referenced this issue Jan 30, 2019
cpuid crate refactoring - part 1: use helper methods instead of bitwi…
1951509 
…se operations when editing the cpuid

firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
serban300 pushed a commit to serban300/firecracker that referenced this issue Feb 7, 2019
cpuid crate refactoring - part 1: use helper methods instead of bitwi…
a93a12e 
…se operations when editing the cpuid

firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
serban300 pushed a commit to serban300/firecracker that referenced this issue Feb 7, 2019
cpuid crate refactoring - part 1: use helper methods instead of bitwi…
bf21504 
…se operations when editing the cpuid

firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
@raduweiss raduweiss added this to the AMD Support milestone Feb 15, 2019
serban300 pushed a commit to serban300/firecracker that referenced this issue Feb 15, 2019
cpuid crate refactoring - part 1: use helper methods instead of bitwi…
c39eb9d 
…se operations when editing the cpuid

firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
@alexandruag alexandruag added the Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled label Feb 15, 2019
serban300 pushed a commit to serban300/firecracker that referenced this issue Feb 15, 2019
cpuid crate refactoring - part 1: use helper methods instead of bitwi…
6b8416a 
…se operations when editing the cpuid

firecracker-microvm#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
acatangiu pushed a commit that referenced this issue Feb 15, 2019
@acatangiu
cpuid crate refactoring - part 1: use helper methods instead of bitwi…
edc44eb 
…se operations when editing the cpuid

#851

Signed-off-by: Serban Iorga <seriorga@amazon.com>
@serban300 serban300 added Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled and removed Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled labels Feb 18, 2019
@serban300 serban300 mentioned this issue Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serban300 serban300

Labels
Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Projects
None yet
Milestone
AMD Support
Development

No branches or pull requests
4 participants
@andreeaflorescu @alexandruag @serban300 @raduweiss