VSock Connection Handshake #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
previously approved these changes
Dec 18, 2019
CHANGELOG.md
Outdated
| ### Changed | ||
|
|
||
| - Vsock host-initiated connections now implement a trivial handshake protocol. | ||
| See the [vsock doc](docs/vsock.md#host-initiated-connections) for details. |
There was a problem hiding this comment.
nit: maybe reference the github issues fixed here.
alxiord
previously approved these changes
Dec 18, 2019
dhrgit
force-pushed
the
vsock-handshake-nocompat
branch
from
d8fb15a
to
6854aca
Compare
acatangiu
previously approved these changes
Dec 18, 2019
Changed the host-initiated vsock connection protocol to include a trivial handshake. The new protocol looks like this: - [host] CONNECT <port><LF> - [guest/success] OK <assigned_host_port><LF> On connection failure, the host host connection is reset without any accompanying message, as before. This allows host software to more easily detect connection failures, for instance when attempting to connect to a guest server that may have not yet started listening for client connections. Signed-off-by: Dan Horobeanu <dhr@amazon.com>
dhrgit
force-pushed
the
vsock-handshake-nocompat
branch
from
6854aca
to
1db04cc
Compare
acatangiu
approved these changes
Dec 18, 2019
alxiord
approved these changes
Dec 18, 2019
This was referenced Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
#1432 #1253 #1443
Description of Changes
Changed the host-initiated vsock connection protocol to include a trivial handshake.
The new protocol looks like this:
CONNECT <port><LF>OK <assigned_host_port><LF>On connection failure, the host connection is reset without any accompanying message, as before.
This allows host software to more easily detect connection failures, for instance when attempting to connect to a guest server that may have not yet started listening for client connections.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria. Where there are two options, keep one.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).clearly provided.
doc changes are included in this PR. Docs in scope are all
*.mdfileslocated either in the repository root, or in the
docs/directory.code is included in this PR.
reflected in
firecracker/swagger.yaml.this PR have user impact and have been added to the
CHANGELOG.mdfile.unsafecode has been added, or, the newly addedunsafecode is unavoidable and properly documented.