Enforce clippy integration test on aarch64 #1961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
reviewed
Jun 17, 2020
lauralt
reviewed
Jun 17, 2020
src/arch/src/aarch64/fdt.rs
Outdated
Comment on lines
315
to
314
| if num_cpus > 1 { | ||
| if cpu_index > 0 { |
There was a problem hiding this comment.
The logic here seems different than it was before. For example, if num_cpus was 2, we were appending the property for every cpu, now we won't append it for the first one.
Also, would be nice to add a comment or a pointer here why we do this check, I have troubles finding it in the aforementioned doc.
There was a problem hiding this comment.
Good catch, @lauralt ! I updated the code and also added a more explicit comment. Take a look!
dianpopa
force-pushed
the
little_fixes_8
branch
2 times, most recently
from
28af370 to
09e5a9b
Compare
serban300
reviewed
Jul 1, 2020
src/arch/src/aarch64/fdt.rs
Outdated
|
|
||
| for cpu_index in 0..num_cpus { | ||
| let more_than_one = vcpu_mpidr.len() > 1; |
There was a problem hiding this comment.
more_tan_one sounds a bit confusing to me. I would rename it to has_multiple_vcpus or I would keep the old variable num_cpus = vcpu_mpidr.len();
Signed-off-by: Diana Popa <dpopa@amazon.com>
Also, adjusted code to also run clippy on gnu code (mostly found in the seccomp logic). Signed-off-by: Diana Popa <dpopa@amazon.com>
lauralt
approved these changes
Jul 1, 2020
serban300
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
Fixes #1007.
Description of Changes
Fixes clippy errors and enforce check in test_style.
rust-vmm.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.firecracker/swagger.yaml.CHANGELOG.md.