seccomp: remove timerfd_create from allow-list #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TimerFd`s are used by rate-limiters, metrics, and balloon device. All of them are created before boot, thus before seccomp filters are applied. This means we don't need `timerfd_create` syscall on our allow-list, and can be removed to tighten it. Signed-off-by: Adrian Catangiu <acatan@amazon.com>
sandreim
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
Fixes #962
Description of Changes
TimerFds are used by rate-limiters, metrics, and balloon device.Since #1494, #1735 and #1736, all of them are created before boot, thus before seccomp filters are applied.
This means we don't need
timerfd_createsyscall on our allow-list, and can be removed to tighten it.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).Any required documentation changes (code and docs) are included in this PR.Any newly addedunsafecode is properly documented.Any API changes are reflected infirecracker/swagger.yaml.Any user-facing changes are mentioned inCHANGELOG.md.