Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot: add container_snapshot_path to load snapshot request #4072

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Aug 24, 2023

  1. snapshot: add container_snapshot_path to load snapshot request

    When a snapshot of a VM created by firecracker-containerd is restored,
    due to the non-deterministic container snapshot path (it depends
    on the containerd snapshotter implementation), the container snapshot
    path at the time of the snapshot creation is different from the
    container snapshot path at the time of the snapshot loading.
    
    Firecracker does not support renaming resources at snapshot-restore, so
    as a workaround we manually substitute the VM state with the path of the
    block device backing the container snapshot to the path of the new
    container snapshot path received from the LoadSnapshot request.
    
    Closes firecracker-microvm#4014
    
    Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
    CuriousGeorgiy committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0dc6a29 View commit details
    Browse the repository at this point in the history