Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVH related integration tests #4073

Draft
wants to merge 4 commits into
base: feature/pvh
Choose a base branch
from

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Aug 24, 2023

Adds PVH related integration tests, such as

  • FreeBSD boots successfully inside of firecracker It does not on m6a.metal
  • Linux compiled with PVH support boots successfully inside of firecracker
  • Linux compiled with PVH support meets boottime SLA of 150ms PVH is not supported on 4.14, which is the kernel version for which we measure boottime in CI.
  • Linux compiled with PVH support boots with initrd

Since the feature we are testing is "PVH boot protocol", the testing matrix we will use here is "PVH-enabled Linux".

See also #3041

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (10949af) 82.36% compared to head (4e0a489) 82.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##           feature/pvh    #4073   +/-   ##
============================================
  Coverage        82.36%   82.36%           
============================================
  Files              225      225           
  Lines            28630    28630           
============================================
  Hits             23580    23580           
  Misses            5050     5050           
Flag Coverage Δ
4.14-c7g.metal 77.75% <ø> (ø)
4.14-m5d.metal 79.68% <ø> (ø)
4.14-m6a.metal 78.80% <ø> (ø)
4.14-m6g.metal 77.75% <ø> (ø)
4.14-m6i.metal 79.67% <ø> (ø)
5.10-c7g.metal 80.66% <ø> (ø)
5.10-m5d.metal 82.33% <ø> (ø)
5.10-m6a.metal 81.55% <ø> (ø)
5.10-m6g.metal 80.66% <ø> (ø)
5.10-m6i.metal 82.32% <ø> (ø)
6.1-c7g.metal 80.66% <ø> (ø)
6.1-m5d.metal 82.33% <ø> (-0.02%) ⬇️
6.1-m6a.metal 81.55% <ø> (ø)
6.1-m6g.metal 80.66% <ø> (ø)
6.1-m6i.metal 82.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We want to add integration tests for PVH boot, which means we need ci
artifacts that have PVH enabled.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat force-pushed the pvh-tests branch 2 times, most recently from 1efb582 to 64b1bb5 Compare September 7, 2023 15:15
@roypat roypat marked this pull request as ready for review September 7, 2023 15:15
Add a test that verifies that firecracker can boot a PVH-enabled linux,
and assert that it actually used the PVH boot protocol.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Enabling CONFIG_XEN_PVH=y is for booting on the actual Xen hypervisor.
To boot using PVH on a non-Xen hypervisor, set CONFIG_PVH=y.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat
Copy link
Contributor Author

roypat commented Sep 11, 2023

I'm putting this back into draft until the initrd issues are resolved

@roypat roypat self-assigned this Oct 2, 2023
@roypat roypat mentioned this pull request Nov 9, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant