Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rebase-snap to snapshot-editor #4075

Merged

Conversation

ShadowCurse
Copy link
Contributor

@ShadowCurse ShadowCurse commented Aug 25, 2023

Changes

Added rebase-snap function to the snapshot-editor tool.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@ShadowCurse ShadowCurse added the Type: Enhancement Indicates new feature requests label Aug 25, 2023
@ShadowCurse ShadowCurse self-assigned this Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 65.38% and project coverage change: -0.03% ⚠️

Comparison is base (f6c28a6) 82.38% compared to head (9cf8713) 82.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4075      +/-   ##
==========================================
- Coverage   82.38%   82.35%   -0.03%     
==========================================
  Files         224      225       +1     
  Lines       28415    28466      +51     
==========================================
+ Hits        23410    23444      +34     
- Misses       5005     5022      +17     
Flag Coverage Δ
4.14-c7g.metal 77.77% <65.38%> (-0.03%) ⬇️
4.14-m5d.metal 79.67% <65.38%> (-0.03%) ⬇️
4.14-m6a.metal 78.78% <65.38%> (-0.03%) ⬇️
4.14-m6g.metal 77.77% <65.38%> (-0.03%) ⬇️
4.14-m6i.metal 79.65% <65.38%> (-0.03%) ⬇️
5.10-c7g.metal 80.69% <65.38%> (-0.04%) ⬇️
5.10-m5d.metal 82.33% <65.38%> (-0.03%) ⬇️
5.10-m6a.metal 81.55% <65.38%> (-0.03%) ⬇️
5.10-m6g.metal 80.69% <65.38%> (-0.04%) ⬇️
5.10-m6i.metal 82.32% <65.38%> (-0.03%) ⬇️
6.1-c7g.metal 80.69% <65.38%> (?)
6.1-m5d.metal 82.33% <65.38%> (-0.03%) ⬇️
6.1-m6a.metal 81.55% <65.38%> (-0.03%) ⬇️
6.1-m6g.metal 80.69% <65.38%> (-0.04%) ⬇️
6.1-m6i.metal 82.32% <65.38%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/snapshot-editor/src/main.rs 5.00% <0.00%> (ø)
src/snapshot-editor/src/edit_memory.rs 66.66% <66.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShadowCurse ShadowCurse force-pushed the snapshot_editor_rebase_snap branch 4 times, most recently from 6842e33 to 14f1161 Compare August 25, 2023 14:14
@ShadowCurse ShadowCurse marked this pull request as ready for review August 25, 2023 14:14
@ShadowCurse ShadowCurse added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 25, 2023
@ShadowCurse ShadowCurse force-pushed the snapshot_editor_rebase_snap branch 2 times, most recently from 4c88305 to 55f0d10 Compare August 31, 2023 09:05
@ShadowCurse ShadowCurse force-pushed the snapshot_editor_rebase_snap branch 2 times, most recently from 8b4d0d0 to 9c9c471 Compare August 31, 2023 11:08
kalyazin
kalyazin previously approved these changes Aug 31, 2023
@wearyzen wearyzen force-pushed the snapshot_editor_rebase_snap branch from dbcf0f0 to 12e57f5 Compare September 1, 2023 11:02
wearyzen
wearyzen previously approved these changes Sep 1, 2023
src/snapshot-editor/src/edit_memory.rs Outdated Show resolved Hide resolved
src/snapshot-editor/src/edit_memory.rs Outdated Show resolved Hide resolved
docs/snapshotting/snapshot-editor.md Outdated Show resolved Hide resolved
src/snapshot-editor/src/edit_memory.rs Show resolved Hide resolved
@ShadowCurse ShadowCurse dismissed stale reviews from wearyzen and kalyazin via 229cc57 September 1, 2023 13:43
@ShadowCurse ShadowCurse force-pushed the snapshot_editor_rebase_snap branch from 12e57f5 to 229cc57 Compare September 1, 2023 13:43
Added `rebase-snap` functionality into `snapshot-editor`.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Added `snapshot-editor` to the `test_5_snapshots`
test as a replacement for `rebase-snap`.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Added info about new `snapshot-editor` function.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Updated changelog with additional
features of the `snapshot-editor`.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
@ShadowCurse ShadowCurse force-pushed the snapshot_editor_rebase_snap branch from 229cc57 to 9cf8713 Compare September 1, 2023 15:10
@ShadowCurse ShadowCurse merged commit bb2fa40 into firecracker-microvm:main Sep 1, 2023
@ShadowCurse ShadowCurse deleted the snapshot_editor_rebase_snap branch September 1, 2023 15:38
@JonathanWoollett-Light JonathanWoollett-Light added this to the 1.5 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants