Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor error propagation #4180

Conversation

JonathanWoollett-Light
Copy link
Contributor

Changes

Refactors error propagation to avoid logging and printing misleading error messages.

Reason

#4176

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (bd55f7f) 83.02% compared to head (c5c5533) 83.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4180      +/-   ##
==========================================
- Coverage   83.02%   83.00%   -0.03%     
==========================================
  Files         222      222              
  Lines       28635    28642       +7     
==========================================
  Hits        23775    23775              
- Misses       4860     4867       +7     
Flag Coverage Δ
4.14-c7g.metal 78.57% <0.00%> (-0.03%) ⬇️
4.14-m5d.metal 80.36% <0.00%> (-0.03%) ⬇️
4.14-m6a.metal 79.50% <0.00%> (-0.03%) ⬇️
4.14-m6g.metal 78.57% <0.00%> (-0.03%) ⬇️
4.14-m6i.metal 80.35% <0.00%> (-0.03%) ⬇️
5.10-c7g.metal 81.48% <0.00%> (-0.03%) ⬇️
5.10-m5d.metal 83.03% <0.00%> (-0.03%) ⬇️
5.10-m6a.metal 82.27% <0.00%> (-0.03%) ⬇️
5.10-m6g.metal 81.48% <0.00%> (-0.03%) ⬇️
5.10-m6i.metal 83.01% <0.00%> (-0.03%) ⬇️
6.1-c7g.metal 81.48% <0.00%> (-0.03%) ⬇️
6.1-m5d.metal 83.03% <0.00%> (-0.02%) ⬇️
6.1-m6a.metal 82.27% <0.00%> (-0.03%) ⬇️
6.1-m6g.metal 81.48% <0.00%> (-0.03%) ⬇️
6.1-m6i.metal 83.01% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/firecracker/src/main.rs 0.22% <0.00%> (-0.01%) ⬇️
src/firecracker/src/api_server_adapter.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonathanWoollett-Light JonathanWoollett-Light added the Status: Blocked Indicates that an issue or pull request cannot currently be worked on label Oct 18, 2023
@JonathanWoollett-Light JonathanWoollett-Light force-pushed the error-refactor branch 2 times, most recently from b507103 to f2e35c5 Compare October 18, 2023 15:49
@JonathanWoollett-Light JonathanWoollett-Light marked this pull request as ready for review October 18, 2023 16:43
@JonathanWoollett-Light JonathanWoollett-Light added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Blocked Indicates that an issue or pull request cannot currently be worked on labels Oct 18, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Refactors error propagation to avoid logging and printing misleading
error messages.

Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
@JonathanWoollett-Light JonathanWoollett-Light merged commit 3806ded into firecracker-microvm:main Oct 20, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants