Vhost user blk metrics #4226
Merged
Vhost user blk metrics #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4226 +/- ##
==========================================
+ Coverage 81.74% 81.76% +0.01%
==========================================
Files 237 238 +1
Lines 29179 29223 +44
==========================================
+ Hits 23853 23894 +41
- Misses 5326 5329 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kalyazin
reviewed
Nov 9, 2023
wearyzen
added
the
Status: Awaiting review
kalyazin
reviewed
Nov 13, 2023
kalyazin
reviewed
Nov 14, 2023
kalyazin
reviewed
Nov 14, 2023
kalyazin
previously approved these changes
Nov 14, 2023
bchalios
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Some minor comments inline and also:
First commit: feat(metrics): Add vhost user metrics
Suggestion for re-wording the commit message:
feat(metrics): add vhost-user metrics
Define metrics for vhost-user devices. These are metrics that are
independent of the device type. They refer to events during
initialization, configuration and activation of a vhost-user device.
ShadowCurse
reviewed
Nov 14, 2023
Define metrics for vhost-user devices. These are metrics that are independent of the device type. They refer to events during initialization, configuration and activation of a vhost-user device. Signed-off-by: Sudan Landge <sudanl@amazon.com>
ShadowCurse
reviewed
Nov 14, 2023
added 6 commits
November 14, 2023 16:31
Use 3 metrics for vhost user block device: 1. to report activate failures. 2. to report failure to read config space. 3. to report time taken to init the device in micro seconds. 4. to report time taken to activate the device in micro seconds. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Report addition of vhost user device metrics with an example. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Flush vhost user device metrics as part of METRICS flush using a proxy serializer. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Make FirecrackerMetrics schema local to validate function so that vhost-user schema added by different tests don't conflict with each other. Move timestamp validation up so that the check doesn't generate any false results. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Add schema to validate breaking change in vhost-user metrics. Re-organize metrics validation function to accommodate vhost-user which has per device metrics but does not have aggregate metrics. Use existing vhost-user tests to check that there is no breaking change in vhost-user-block device metrics. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Add basic test to check shared inc and store metrics. Signed-off-by: Sudan Landge <sudanl@amazon.com>
ShadowCurse
approved these changes
Nov 14, 2023
kalyazin
approved these changes
Nov 14, 2023
bchalios
approved these changes
Nov 14, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
Vhost user block is a new device which doesn't have any metrics.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.