Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test to check if killing microvm works as expected #4436

Merged
merged 2 commits into from
Feb 9, 2024
Merged

chore: test to check if killing microvm works as expected #4436

merged 2 commits into from
Feb 9, 2024

Commits on Feb 9, 2024

  1. chore: test to check if killing microvm works as expected 

    Change:
Add a test to make sure there is no change in behaviour in
killing firecracker_pid.

Reason:
In our CI we pass `--new-pid-ns` along with `--daemonize` and so
firecracker pid can be read from the file `firecracker.pid`
present in the jailers root directory.
However, if there is a change in behaviour that leads to this file not
having the actual firecracker pid then it could cause a regression.

Signed-off-by: Sudan Landge <sudanl@amazon.com>
    Sudan Landge committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4679e1b View commit details
    Browse the repository at this point in the history

  2. doc: update known limitation of jailer 

    da92bf6 commit
changed the behaviour of the pid returned by the jailer so,
add a known limitation explaining that and suggest a workaround
to get the Firecracker pid.

Signed-off-by: Sudan Landge <sudanl@amazon.com>
    Sudan Landge committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    81b541e View commit details
    Browse the repository at this point in the history