Bump userfaultfd to 0.8.1 #4568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UFFD support is not compatible with newer kernels as there was a new ioctl option added that the older userfaultfd version does not recognize:
```
[PUT /snapshot/load][400] loadSnapshotBadRequest &{FaultMessage:Load snapshot error: Failed to restore from snapshot: Failed to load guest memory: Error creating guest memory from uffd: Failed to register memory address range with the userfaultfd object: Unrecognized ioctl flags: 284}
```
This was reported in bytecodealliance/userfaultfd-rs#61 and fixed in bytecodealliance/userfaultfd-rs#62
Signed-off-by: Vadim Berezniker <vadim@buildbuddy.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4568 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 255 255
Lines 31278 31278
=======================================
Hits 25692 25692
Misses 5586 5586
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @vadimberezniker . Thanks for your contribution! Could you do a couple of minor things:
|
|
Hi @vadimberezniker, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Depend on newer version of userfaultfd
Reason
UFFD support is not compatible with newer kernels as there was a new ioctl option added that the older userfaultfd version does not recognize:
This was reported in bytecodealliance/userfaultfd-rs#61 and fixed in bytecodealliance/userfaultfd-rs#62
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.